jsnext:main -> module #3904
Merged
jsnext:main -> module #3904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per rollup & webpack. https://github.com/rollup/rollup/wiki/pkg.module
|
|
|
Yep. That's correct these days. |
|
@evan-scott-zocdoc maybe stupid question but does this fix the webpack all-languages-together issue or a separate problem. |
|
Talking about this webpack/webpack#3128 (comment) |
|
I don't think it would, no. Not unless the library switched to using the function variant of import ( |
orifn
pushed a commit
to orifn/moment
that referenced
this pull request
Aug 3, 2017
* develop: Added Gujarati locale for moment (moment#4004) Add bambara language. (moment#4001) NL and BE locale weekDaysMin should not be capitalized, updated to lowercase. (moment#3961) moment#1428: Updated Danish 'L' dateformat to use dots rather than slashes, aligning with article from DSN. (moment#3945) update travis to only test back to node 4 jsnext:main -> module (moment#3904) Fix localeData months on Greek (moment#3868) Fix moment#4060: bundle.generate returns a Promise now compute monthDiff only for the type that needs it convert long ternary operator to switch for easier readability Changed setter check behavior to use isNaN() for checking whether an input is a valid value Removed unwarranted spaces, changed illegal quotes Added semicolon to helper Added new line in helper file Added helper 'isNumeric' to test values for validity in setters Update for check, Added comment as requested in: moment#3504 Fix for conditional in src/lib/units/offset.js:164 - I interpreted this is as simply not catching being a falsy (but assumedly valid) time zone modifier (_tzm?) of 0
ichernev
added a commit
to ichernev/moment
that referenced
this pull request
Oct 10, 2017
This reverts commit aea6a97.
ichernev
added a commit
to ichernev/moment
that referenced
this pull request
Oct 10, 2017
This reverts commit aea6a97.
This was referenced Oct 11, 2017
fbonzon
pushed a commit
to fbonzon/moment
that referenced
this pull request
Oct 28, 2017
Per rollup & webpack. https://github.com/rollup/rollup/wiki/pkg.module
fbonzon
pushed a commit
to fbonzon/moment
that referenced
this pull request
Oct 28, 2017
This reverts commit aea6a97.
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per rollup & webpack2.
https://github.com/rollup/rollup/wiki/pkg.module
https://webpack.js.org/configuration/resolve/#resolve-mainfields