Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[misc] upgrade qunit to latest #4525

Merged
merged 2 commits into from
Apr 3, 2018
Merged

[misc] upgrade qunit to latest #4525

merged 2 commits into from
Apr 3, 2018

Conversation

marwahaha
Copy link
Member

@marwahaha marwahaha commented Mar 31, 2018 •
edited

This should fix build errors in Node 4.

  • qunit now is node-qunit
  • removes a circular dependency by moving a function from qunit.js to qunit-locale.js
  • expect -> assert.expect
  • update syntax for qunit
  • check in package-lock.json

@icambron
Copy link
Member

why the change to using QUnit as a global?

@marwahaha
Copy link
Member Author

@icambron i was following https://qunitjs.com/upgrade-guide-2.x/

@marwahaha marwahaha mentioned this pull request Apr 2, 2018
Merged
@marwahaha marwahaha merged commit 74f5790 into develop Apr 3, 2018
@marwahaha marwahaha deleted the km/update-qunit branch April 3, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icambron icambron icambron approved these changes

@ichernev ichernev Awaiting requested review from ichernev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marwahaha @icambron