[bugfix] Added HTML5_FMT to moment.d.ts #4495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calidus
changed the title
Calidus
changed the title
|
Any update on this? Running into the same issue |
ragingdave
reviewed
Mar 27, 2018
moment.d.ts
Outdated
| @@ -716,6 +716,19 @@ declare namespace moment { | |||
|
|
|||
| export var defaultFormat: string; | |||
| export var defaultFormatUtc: string; | |||
|
|
|||
| export var HTML5_FMT: { | |||
| DATETIME_LOCAL:string, | |||
There was a problem hiding this comment.
I would guess that the styling here would need to be updated prior to it being approved for merging so that like the code above it, there should be a space after the colon and the type.
There was a problem hiding this comment.
Oh good call. I have updated it.
|
Thanks for this! The build errors will be fixed by #4525 . |
This was referenced Apr 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issue #4494