[feature] Accept custom relative thresholds in duration.humanize #4296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TWiStErRob
reviewed
Dec 4, 2017
src/test/moment/duration.js
Outdated
| assert.equal( | ||
| moment.duration({seconds: 10}).humanize({thresholds: thresholds, withSuffix: true}), | ||
| 'in a minute', | ||
| '100 seconds = a minute (with thresholds and suffix)' |
There was a problem hiding this comment.
{seconds: 10} VS "100 seconds", one of these is wrong.
There was a problem hiding this comment.
Looks like the message has an extra zero. I'll put up a fix.
TedDriggs
changed the title
|
Merged in 757d4ff |
ichernev
added a commit
that referenced
this pull request
Apr 25, 2020
[feature] Accept custom relative thresholds in duration.humanize
This was referenced Apr 30, 2020
|
This allegedly is in 2.25, but I still don't seem to have it after upgrading to 2.25.3. EDIT: It appears to be missing in the ts3.1-typings, which my Angular project is deciding to use for some reason. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4295