Timezone guess utc offset check #745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This reverts commit e8710dd.
|
Somehow this MR includes a bunch of generated files. About this particular issue, it's best to let users decide whether to use Intl or not, check #873 (comment) So I'd merge something that adds an options object to guess, backwards compatible with existing code, that lets users specify Intl or in-house or both. Then we could put a note about buggy Intl and let users decide how to handle it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue from #517.
Some background. CST stands for Central Standard Time and Chicago Standard Time. PST stands for Pacific Standard Time and Philippines Standard Time. This causes Intl API to be unreliable in older versions of Chrome and Electron.