Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data: Add 2024a #1093

Closed
wants to merge 1 commit into from
Closed

data: Add 2024a #1093

wants to merge 1 commit into from

Conversation

tmkx
Copy link
Contributor

@tmkx tmkx commented Feb 2, 2024

close #1091
close #1092

@Flightfreak
Copy link

Thx @tmkx! Out of interest, is there a described procedure or automated script to incorporate IANA changes?

@tmkx
Copy link
Contributor Author

tmkx commented Feb 2, 2024

Yes, you can execute

npx grunt data
npx grunt build

to update it :)

@gilmoreorless
Copy link
Member

Quick note here: Contributor PRs to update the data are generally not accepted as-is. The wild variances in tooling on different machines have caused several bugs in past data updates. This isn't a judgement on the contributors, just a reflection of hidden subtle incompatibilities in underlying systems. It's hard to verify a data change we haven't built ourselves.
(Case in point, this PR contains some automated test fixes that are completely unrelated to the tzdb data, and just a quirk of it being the first build of 2024.)

Over the last few weeks I've worked on a fully automated data update system, anticipating this tzdb release. Once I've got some settings tweaked, I can fix it up over the weekend. Then for all future data updates, it's a single press of a button to build a PR.

@tmkx
Copy link
Contributor Author

tmkx commented Feb 2, 2024

@gilmoreorless thanks for your work and friendly note

@tmkx tmkx closed this Feb 2, 2024
@tmkx tmkx deleted the data/2024a branch February 2, 2024 08:36
@m-urukov
Copy link

m-urukov commented Feb 2, 2024

@gilmoreorless Thanks you! We are really looking forward to the release of 2024a ❤️

@Flightfreak
Copy link

@gilmoreorless understood. A containerised solution and a GitHub workflow?
Anyway, sounds like a good step forward!

@gilmoreorless
Copy link
Member

A containerised solution and a GitHub workflow?

Pretty much! https://github.com/moment/moment-timezone/blob/6c31d29936a39207be6420e82e9f2bf2f231c6da/.github/workflows/build-data.yml

Managed to get it working after some false starts: #1095

@gilmoreorless
Copy link
Member

Data 2024a is now available in release 0.5.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2024a released Kazakhstan will switch to a single time zone, UTC+05:00, on March 1, 2024.
4 participants