Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding country functionality from metadata #410

Closed
wants to merge 11 commits into from

Conversation

adgrace
Copy link

@adgrace adgrace commented Nov 1, 2016

PR for adding country functionality from metadata.

API:
var zones = moment.tz.zonesForCountry('US'); // returns ['America/Chicago', ' America/New_York', etc...]
var country = moment.tz.zone('America/Los_Angeles').country; // returns ['US']

Countries has been added to each zone containing the countries within the zone as well as a countries section containing the abbreviation and zones inside to both the packed and unpacked data.

I welcome any feedback and feel free to ask any questions or for further development.

Sorry for the delay adding the feature, I am a student at university and have a high workload at the moment.

Issues requesting the feature:

Original Pull Request: #377 ** had some difficulty with not being able to merge and so created new pull request, sorry for any inconvenience.

@jsf-clabot
Copy link

jsf-clabot commented Nov 1, 2016

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ mj1856
✅ DanielRuf
✅ adgrace
❌ HNDeploys

@maggiepint
Copy link
Member

Something is wrong here. Moment should not be in the source.

@adgrace
Copy link
Author

adgrace commented Nov 6, 2016

I'm not sure how that happened! Do I need to run "grunt clean"?

On 6 Nov 2016, at 2:49 pm, Maggie Pint notifications@github.com wrote:

Something is wrong here. Moment should not be in the source.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@mattjohnsonpint
Copy link
Contributor

You've committed way more files than are actually part of the project. Did you maybe modify or delete your .gitignore file?

@marwahaha
Copy link
Member

I can jump onto this @alexgrace95 if you're busy right now. It should be a quick fix, or we can chat online about how to fix this.

@mattjohnsonpint
Copy link
Contributor

@alexgrace95 - ping

@adgrace
Copy link
Author

adgrace commented Dec 21, 2016

Hi @mj1856 & @marwahaha.
Sorry about my ultra slow reply, I have been snowed under with final year university work! I emailed @marwahaha with the email address on his GitHub profile but I am not sure if it is still active as I have had no reply?
I have a little bit of time over christmas and would like to get the pull request finished! @marwahaha please let me know how you think it should be resolved? @mj1856 could this have happened if I had pulled from the Master instead of the Dev?
Thanks,
Alex

@adgrace
Copy link
Author

adgrace commented Dec 22, 2016

I have removed Moment from the source (I think may have been caused by running "bower install" at some point) and resolved the conflicts.
Thank you @marwahaha very much for all your help!

@mattjohnsonpint
Copy link
Contributor

Please rebase

@marwahaha
Copy link
Member

Out of curiosity @mj1856 , what's wrong with a squash and merge? Just trying to understand.

Added full country functionality

removed moments from the source

resolving conflicts

removed <<<< and >>> and ran grunt release
@adgrace
Copy link
Author

adgrace commented Dec 24, 2016

I have squashed and rebased and resolved the conflicts! :)

@adgrace
Copy link
Author

adgrace commented Mar 23, 2017

Hi @mj1856 & @maggiepint,
Is this ready to be merged?

@reimertz
Copy link

@alexgrace95 thank you soo much for doing this! I have been looking for this dataset for about 3 days and was about to give up and just create it myself. 🙏

@maggiepint
Copy link
Member

Can we rebase the built files out of this pull? If so, will merge.

@cmalard
Copy link

cmalard commented Dec 31, 2017

Hello there, @alexgrace95 do you still have availability to rebase this PR ? :-) Would be much appreciated 🎉

@adgrace
Copy link
Author

adgrace commented Dec 31, 2017 via email

@xicovarisco
Copy link

Do you guys have an ETA on when this functionality will be merged?

@adgrace
Copy link
Author

adgrace commented Mar 19, 2018

Hi All,
I have resolved the conflicts.
@maggiepint or @mj1856 please can you review?
Sorry for the delay, I have been really busy with other exciting projects.

@NuclearMachine
Copy link

This is stupid. A highly sought and needed feature has not been merged in 3 years.

@dtminnaar
Copy link

I am also looking for this feature 👍

ellenaua added a commit that referenced this pull request Feb 19, 2020
ellenaua added a commit that referenced this pull request Feb 19, 2020
@ellenaua
Copy link
Contributor

It's going tomorrow to production. Version 0.5.28
I'll do more tests in my morning & release.

@adgrace
Copy link
Author

adgrace commented Feb 20, 2020

@ellenaua Let me know if you need it rebased or anything. Look forward to it being merged 😊

ellenaua added a commit that referenced this pull request Feb 20, 2020
ellenaua added a commit that referenced this pull request Feb 20, 2020
ellenaua added a commit that referenced this pull request Feb 21, 2020
ellenaua added a commit that referenced this pull request Feb 21, 2020
@ellenaua
Copy link
Contributor

Tadaaam 🥇 🥇
It was too hard to resolve conflicts, I "picked" commits from your branch @adgrace but mentioned you in commit messages so that world knows the author.
https://momentjs.com/timezone/docs/#/using-timezones/getting-country-zones/

@ellenaua ellenaua closed this Feb 21, 2020
ellenaua added a commit that referenced this pull request May 16, 2020
* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

Co-authored-by: Brinley Ang <brinley@unbolt.net>
ellenaua added a commit that referenced this pull request May 16, 2020
* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
ellenaua added a commit that referenced this pull request May 16, 2020
* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua added a commit that referenced this pull request May 17, 2020
* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua added a commit that referenced this pull request May 17, 2020
* Develop -> Master release 0.5.29 (#849)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua added a commit that referenced this pull request May 17, 2020
…856)

* Develop -> Master release 0.5.29 (#849) (#854)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails (#855)

* Develop -> Master release 0.5.29 (#849)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Release0.5.31

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
ellenaua added a commit that referenced this pull request May 23, 2020
* Develop -> Master release 0.5.29 (#849)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise in Node 4 and 6 build fails (#856)

* Develop -> Master release 0.5.29 (#849) (#854)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails (#855)

* Develop -> Master release 0.5.29 (#849)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Release0.5.31

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Added copyright info

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
@Soullighter
Copy link

Far as i see, there is no solution to do this?
var country = moment.tz.zone('America/Los_Angeles').country; // returns ['US']

@lvillacin
Copy link

Same thoughts with @Soullighter canmoment.tz.zone().country be implemented?

@Soullighter
Copy link

Soullighter commented Jun 16, 2021

@Ivillacin
Check my codepen for solution
https://codepen.io/Soullighter/pen/MWKVvvP
Far as i remember it’s under get_locale variable

ellenaua added a commit that referenced this pull request Nov 10, 2021
* Develop -> Master release 0.5.29 (#849)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise in Node 4 and 6 build fails (#856)

* Develop -> Master release 0.5.29 (#849) (#854)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails (#855)

* Develop -> Master release 0.5.29 (#849)

* Merged @adgrace pull request #410

* Merged @adgrace pull request #410

* Bugfix: zone country is detected incorrect if link is used

* Bugfix: zone country is detected incorrect if link is used

* Decrease build size

* Order zones by name

* Updated 2019c files

* Updated changelog

* Resolve es6 loading issue where moment is undefined

* Removed node 4 and 6 from travis.yml

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Fixed changelog to represent proper release versions (#839)

* Fixed changelog to represent proper release versions

* Removed node v4 and 6 from travis build, because as pointed by other the ES6 syntax now included in the lib aren't supported with those earlier node versions.

Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>

* Resolves es6 module loading issue

* Corrected version numbers (#845)

Version numbers were incorrect so fixed it.

* Resolves es6 module loading issue

* Yet another PR adding TypeScript declarations (#530)

* Adds TypeScript declarations for moment-timezone

* Remove unnecessary `moment.` qualification in typings

* Move exported types to top-level so that they can all be imported as named imports

- Zone class must exist at `tz.Zone` because that's where it's exposed at runtime, but the `Zone` interface is still re-exported as a named export

* tsc invocation always uses locally installed tsc

Co-authored-by: Elena Sharovar <elenasharovar@gmail.com>

* Release 0.5.29

* Release 0.5.29

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Fixing Grunt version to 1.0.4 otherwise it fails

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Release0.5.31

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>

* Added copyright info

* 2021a (#928)

* Create issue_template.md

* 2021a (#927)

* 2021a

* 2021a

* 2021e

Co-authored-by: Brinley Ang <brinley@unbolt.net>
Co-authored-by: praneeth-m <praneeth.m@hotmail.com>
Co-authored-by: Jackalex36 <beatboxace@gmail.com>
Co-authored-by: Alexandre Couillard <jackalex36@hotmail.com>
Co-authored-by: Andrew Bradley <cspotcode@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet