Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add country to the Zone object #400

Closed
acrodrig opened this issue Oct 20, 2016 · 7 comments
Closed

Add country to the Zone object #400

acrodrig opened this issue Oct 20, 2016 · 7 comments

Comments

@acrodrig
Copy link

Sorry if I misunderstanding the way to use the library. I have a requirement to get the country code from the time zone name (for example US would correspond to America/Los_Angeles. Currently the country is not percolating through in the Zone object as described here:

http://momentjs.com/timezone/docs/#/zone-object/

Am I missing something? Is it possible to put a request to add it?

Thanks.

@adgrace
Copy link

adgrace commented Oct 20, 2016

Yes this is what is being achieved with PR 377 (#377). This is my first pull request and it needs to be adjusted a little before it is merged, I plan on completing it soon but have been very busy with University and another project recently. I will finish this Pull Request ASAP.

@mattjohnsonpint
Copy link
Contributor

This is one of two APIs that will be in Alex's #377. Will keep this open for now as a reminder. Thanks.

@acrodrig
Copy link
Author

Thanks. I am really interested in this, so let me know if I can contribute (tests/docs/whatever).

@acrodrig
Copy link
Author

If it helps anyone I ended up doing patching moment-timezone in a manner similar to the following gist: https://gist.github.com/acrodrig/9c10ef9ba69f2da2b74c05400fd5eaed.

@adgrace
Copy link

adgrace commented Oct 28, 2016

Hi Andres,
I am hoping to get this done this weekend :)

On 28 Oct 2016, at 8:22 pm, Andres Rodriguez notifications@github.com wrote:

Thanks. I am really interested in this, so let me know if I can contribute (tests/docs/whatever).


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

@adgrace
Copy link

adgrace commented Nov 1, 2016

Pull Request has been submitted and is passing all checks:
#410

Appreciate any feedback!

@Soullighter
Copy link

If it helps anyone I ended up doing patching moment-timezone in a manner similar to the following gist: https://gist.github.com/acrodrig/9c10ef9ba69f2da2b74c05400fd5eaed.

Are you available to find that gist and share again with us?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants