Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toISODate, toISO and toSQLDate methods could return null when an InvalidDate is provided #1406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edoardomistretta
Copy link

toISODate method could return null even if it is not explicit in the method type.

import { DateTime } from "luxon";

const invalidDate = new Date('2023-15-56'); // -> InvalidDate
const dt = DateTime.fromJSDate(invalidDate) // -> DateTime
const isoDt = dt.toISODate(); // -> null

A pull request for DefinitelyTyped is already opened in DefinitelyTyped/DefinitelyTyped#64919

@linux-foundation-easycla
Copy link

CLA Not Signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants