Add lastMoment getter to Interval

[ties-s]

Convenient way to get the last moment that is actually included in the interval. Makes it easier to properly use the fact that intervals are half open.

My use case: displaying end date of a monthly subscription.

I'm not sure lastMoment is the best way to name this, but it was the first thing that I thought of.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ties-s / name: Ties (011eaff, d0a2f1a)

[icambron]

@ties-s So first, sorry for taking so long to get to this.

I'm open to this but a couple of notes:

1. I think lastMillisecond() is a better name - the term "moment" is not defined in Luxon's documentation or API
2. It needs test, as simple as those tests would be.

[ties-s]

@icambron thank you for your response.

I'll look into the tests.

For the name, lastMillisecond might suggest a numeric return value. Some other options I thought of, but are also not great:

• inclusiveEnd
• endInclusive
• lastInstant

[icambron]

@ties-s sorry a second time for the slow review here. I agree with your concern that lastMillisecond sounds numeric. How about lastDateTime

[ties-s]

@icambron That sounds good, updated the PR to reflect that new function name

[diesieben07]

@ties-s Looks good to me! Once we have 3.4.2 out with a fix for the current Duration issues, this can be merged.