Skip to content

Commit

Permalink
Allow pypy 3.8/7.3.10 to fail the coverage limit
Browse files Browse the repository at this point in the history
There's an issue with coverage and pypy `3.8.15[pypy-7.3.10-final]`, see links for details:
- nedbat/coveragepy#1515
- https://foss.heptapod.net/pypy/pypy/-/issues/3876
  • Loading branch information
Tom Hendrikx committed Dec 27, 2022
1 parent c609899 commit 1417c30
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/tests.yaml
Expand Up @@ -10,7 +10,13 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python_version: ["3.7", "3.8", "3.9", "3.10", "3.11", "pypy-3.7", "pypy-3.8", "pypy-3.9"]
python_version: ["3.7", "3.8", "3.9", "3.10", "3.11", "pypy-3.7", "pypy-3.9"]
coverage_fail_under: [90]
include:
# https://github.com/nedbat/coveragepy/issues/1515
# https://foss.heptapod.net/pypy/pypy/-/issues/3876
- python_version: "pypy-3.8"
coverage_fail_under: 0
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -27,7 +33,7 @@ jobs:
python -m pip install -r test_requirements.txt
- name: Run unittests
run: python -m pytest
run: python -m pytest --cov-fail-under=${{ matrix.coverage_fail_under }}

- name: Verify dependencies
run: python -m safety check
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Expand Up @@ -12,7 +12,7 @@ mock_use_standalone_module = true
addopts = """
--cov mollie/
--no-cov-on-fail
--cov-fail-under=80
--cov-fail-under=90
--cov-report=term-missing
--cov-branch
"""
Expand Down

0 comments on commit 1417c30

Please sign in to comment.