fix: add missing status type #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Hi @casperiv0, I would suggest this to be an enum, similar to |
|
@janpaepke done! |
|
@casperiv0 We've about to issue a major version bump as per #338. Would you be able to update to the newer version once it's cut? Planning to cut this week. New version will require Node >= 14. If something is blocking you from updating we could backport to the current major. |
edorivai
force-pushed
the
fix/add-missing-status-type
branch
from
5258ec7
to
872c448
Compare
|
Sure! I'm be able to update to the newer version once it's out. Though, to confirm, you simply mean here: rebase my PR from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes::
statusfield for getting the payment methods.