Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 3484 Show repeats in variable list #3755

Closed
wants to merge 2 commits into from

Conversation

connoratrug
Copy link
Contributor

@connoratrug connoratrug commented May 16, 2024

Closes #3484

alt styling
see: #3758
see: #3759

What are the main changes you did:
-Added the number of repeats ( if any) next to the variable name in the variable list

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Contributor

@timcadman timcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Is it possible to amend the text wrapping so that "(x repeats") remains together on the same line? See below: "(1" is on the first line, everything else on the second

Captura de pantalla 2024-05-16 a las 10 44 14

what would you like to happend when the text is larger then the max column with , see alternative PR's

#3758 and #3759

@timcadman
Copy link
Contributor

My vote would be for a mix (sorry to be difficult!) - #3759 but with a '+' next to the number.

How easy is it to display "1 repeat" when singular and "2 repeats" (etc) when plural?

@connoratrug
Copy link
Contributor Author

suggest to first make a design of the desired solution before implementing in code, as some exploring / iterating is needed

@timcadman
Copy link
Contributor

This is what I had in mind after the variable ...

Captura de pantalla 2024-05-16 a las 14 37 04

@connoratrug
Copy link
Contributor Author

This is what I had in mind after the variable ...

Captura de pantalla 2024-05-16 a las 14 37 04

i tried that it looked a bit messy/ less clear to me, and what does the '+' sign mean in ? , anyway i propose to do the design details in figma ( or other tool ) the whole checkout, commit , PR , build preview , review loop takes a bit to long for design details imo, i'll make some figma options add link to those

@timcadman
Copy link
Contributor

Yeah sorry, I don't know how to use figma or much design skills myself. I don't think we should spend much time on this - it is a stop-gap measure to stop people complaining and long-term we might think about a more complete solution. I would suggest to go with option 2 as is.
@mswertz?

@mswertz
Copy link
Member

mswertz commented May 17, 2024

This is what I had in mind after the variable ...

Captura de pantalla 2024-05-16 a las 14 37 04

Yes that is also what I have in mind :-)

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants