Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit/offset/where should be applied before json nested joins otherwise queries get slow. closes #3666 closes #3481 closes #3652."" #3751

Merged
merged 3 commits into from
May 16, 2024

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented May 15, 2024

Reverts #3750

We need to fix the nested queries from BBRMI which were created in this PR

Copy link

sonarcloud bot commented May 15, 2024

Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did a functional review:

  • Tested several filters in the Directory App and these all work fine again.
  • Also tested the table explorer by updating rows etc, this all works fine.

@mswertz mswertz merged commit 20dec58 into master May 16, 2024
6 checks passed
@mswertz mswertz deleted the revert-3750-revert-3719-fix/limit_offset_simple branch May 16, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants