Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed bottom margin in breadcrumbs #3748

Merged
merged 3 commits into from
May 16, 2024
Merged

Conversation

davidruvolo51
Copy link
Contributor

What are the main changes you did:

There is always a white space between breadcrumbs and the main content (router-view)

Screenshot 2024-05-14 at 15 05 57

This PR removes the bottom margin so that the main content sits directly below the breadcrumbs.

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@davidruvolo51 davidruvolo51 marked this pull request as ready for review May 16, 2024 10:14
@davidruvolo51 davidruvolo51 merged commit 8c1853c into master May 16, 2024
6 checks passed
@davidruvolo51 davidruvolo51 deleted the fix/breadcrumbs-margin branch May 16, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants