-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: proper handling of 'na' values #3747
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. There are a couple of linting issues flagged by pylance, but everything works as expected.
@@ -610,7 +610,7 @@ def _prep_data_or_file(file_path: str = None, data: list | pd.DataFrame = None) | |||
if type(data) is pd.DataFrame: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should isinstance
be used here instead?
https://pylint.readthedocs.io/en/latest/user_guide/messages/convention/unidiomatic-typecheck.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pylance also flags this block as unreachable.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What are the main changes you did:
pandas
handles 'na' values when creating a DataFrame from either a csv or list/dict data_validate_graphql_response
methodhow to test:
save_schema
tests, named 'NA' with statusnumpy.nan
. You can verify that the name is stored as 'NA', and the status is left emptytodo: