Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated css resets; changed footer element #3746

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

davidruvolo51
Copy link
Contributor

What are the main changes you did:

In PR #3683, the primary router view was changed to a <main> element and a primary <footer> element was added. This was important for other reasons listed in the PR. As a result, a few changes to molgenis-viz library is needed. These are -

  • Update resets.scss: need to be make sure the css selector points to the main element
  • Remove footer element generated by the <PageFooter> component.

how to test:

  • navigate to the preview.
  • in the pet store schema, navigate to any of the dashboard apps. (e.g., pet store/gportal, pet store/cranio-public, etc.)
  • There should be: 1) no more left and right padding, 2) the custom footer should be displayed instead of the default molgenis one

todo:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@davidruvolo51 davidruvolo51 marked this pull request as ready for review May 14, 2024 13:04
@davidruvolo51 davidruvolo51 merged commit b81d478 into master May 16, 2024
6 checks passed
@davidruvolo51 davidruvolo51 deleted the fix/vue-apps branch May 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants