feat(schema): interactive docs for profiles (poc) #3725
Conversation
|
You will see something like 
|
backend/molgenis-emx2/src/main/java/org/molgenis/emx2/SchemaMetadata.java
Outdated
Show resolved
Hide resolved
...olgenis-emx2-graphql/src/test/java/org/molgenis/emx2/graphql/TestGraphqlCrossSchemaRefs.java
Outdated
Show resolved
Hide resolved
| @@ -25,7 +25,7 @@ public Schema(SchemaMetadata schema, boolean minimal) { | |||
| .map(entry -> new Setting(entry.getKey(), entry.getValue())) | |||
| .toList(); | |||
| List<TableMetadata> list = new ArrayList<>(); | |||
| list.addAll(schema.getTablesIncludingExternal()); | |||
| list.addAll(schema.getTables()); | |||
There was a problem hiding this comment.
what is the impact of this core behaviour change?
There was a problem hiding this comment.
this is the same point as previous. Should not be an issue. Tests are green so that is promising. Just a bit of smoke testing with data explorer and forms to verify.
There was a problem hiding this comment.
this was previously reverted due to issues on certain pages ( please check pr history for notes on revert)
There was a problem hiding this comment.
ah, I will carefully review. Supposedly that should be fixed by now in the client but double check in order if there are other apps still depending on it (e.g. old catalogue components).
There was a problem hiding this comment.
I indeed found an issue in the client where it still depended on this (in getColumnIds, nested columns from refTables in other schemas couldn't be found; fix included for that too).
backend/molgenis-emx2-graphql/src/main/java/org/molgenis/emx2/json/Table.java
Show resolved
Hide resolved
|
Why is this app/view not coded using components ? it makes the ui feel a bit more an art project than part of the emx2 ui, i.e. what is this code supposed to do ? |
thx for review. This is indeed like an art project aiming to produce visual documentation. It really is a template, not really an 'app' (although it has some interactivity). I will convert into components only when components are used multiple times. |
…ui_create_schema_from_profiles
mswertz
changed the title
…s getColumnIds of nested table from other schema)
…ui_create_schema_from_profiles
|
What are the main changes you did:
how to test:
todo: