Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit/offset/where should be applied before json nested joins otherwise queries get slow. closes #3666 closes #3481 closes #3652. #3719

Merged
merged 9 commits into from
May 13, 2024

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented May 8, 2024

closes #3652.
closes #3476

What are the main changes you did:

  • made sure filter, limit, offset, order by are applied before json is build

how to test:

  • compare speed on this PR vs another PR. See example below

@mswertz
Copy link
Member Author

mswertz commented May 9, 2024

@mswertz mswertz changed the title fix: limit/offset/where should be applied before json building (simpliefied alternative) fix: limit/offset/where should be applied before json nested joins otherwise queries get slow May 9, 2024
@mswertz mswertz changed the title fix: limit/offset/where should be applied before json nested joins otherwise queries get slow fix: limit/offset/where should be applied before json nested joins otherwise queries get slow. closes #3666 closes #3481 May 9, 2024
@mswertz mswertz requested a review from timcadman May 9, 2024 12:05
Copy link
Contributor

@timcadman timcadman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a big speed improvement, nice work :) I wasn't sure how to measure the times precisely as you did, but I can confirm that the PR speeds things up significantly.

Copy link

sonarcloud bot commented May 13, 2024

@mswertz mswertz changed the title fix: limit/offset/where should be applied before json nested joins otherwise queries get slow. closes #3666 closes #3481 fix: limit/offset/where should be applied before json nested joins otherwise queries get slow. closes #3666 closes #3481 closes #3652. May 13, 2024
@mswertz mswertz merged commit 4a5f761 into master May 13, 2024
6 checks passed
@mswertz mswertz deleted the fix/limit_offset_simple branch May 13, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants