-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: aggregation dashboard #3705
Conversation
For a new PR(s) -
|
The margins and chart label work break is now working. However, some of the labels have a forward slash. Do you want to use a regex here to break labels at spaces and slashes? Or should these values be revised at the source? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, David! I have some minor comments:
-Is the 'apply filters' button necessary? I found it a bit hard to notice that the filters were not applied straight away by clicking on the graphs.
-The labels of the x-axis of the sampling period overlap, making them illegible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. If Brenda says 'go' we can go.
The figure "Number of cases by stage at diagnosis" should also specify that this is about distant metastasis. Can you make this: "Number of cases by stage at diagnosis, distant metastasis" yes no unknow |
PRIMARYTUMORSITE - can this contain spaces between the words? |
Quality Gate passedIssues Measures |
Due to merge conflicts and rebase issues with #3376, a new branch was created and this PR was opened.
What are the main changes you did:
how to test:
catalogue-demo/aggregation-dashboard
Input needed / notes:
Todo:
fix gap around app: needs a new PR