Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't remove filters from store. closes #3087 #3694

Merged
merged 10 commits into from
May 23, 2024

Conversation

MaxPostema
Copy link
Contributor

@MaxPostema MaxPostema commented May 1, 2024

fixes: #3087

What are the main changes you did:

  • the filters are cleared from there store if they are no longer in the url.. this makes using a store useless, and we want to have the state saved.

how to test:

  • Set filters
  • Go in a biobank
  • Go back to the main screen
  • Expect the filters to still be set

@MaxPostema MaxPostema marked this pull request as ready for review May 2, 2024 07:05
Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I use the 'Back to the catalogue' link in a biobank or collection or network details view then the filters are still lost. It does seem to work with the back button.

@mswertz mswertz changed the title fix: don't remove filters from store fix: don't remove filters from store. closes #3087 May 22, 2024
Copy link
Member

@esthervanenckevort esthervanenckevort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er functioneel wel goed uit, maar filter hangt nu op 'Neoplasms' of 'Austria'. Kun je met de main branch updaten, want als het goed is is dat issue daar gefixt.

Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@MaxPostema MaxPostema merged commit c8d968a into master May 23, 2024
6 checks passed
@MaxPostema MaxPostema deleted the fix/dont-remove-filters-from-store branch May 23, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory App: Back button in the cards should preserve the state
2 participants