Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
how to test:
$JAVA_HOME
and run./gradlew run
todo:
requirements
page in docs with exact details instead of info being scattered in the documentation?Changelog:
targetCompatibility
/sourceCompatibility
from the rootbuild.gradle
toapps/build.gradle
due to the following error:rootProject.ext.javaVersion
).Failed tests (local run through IntelliJ IDEA)
AssertionFailedError
When testing everything in the project using jUnit, it gives the following error:
java.lang.reflect.InaccessibleObjectException: Unable to make field final java.util.Map java.util.Collections$UnmodifiableMap.m accessible: module java.base does not "opens java.util" to unnamed module @3d680b5a
However, when running
WebApiSmokeTests.java
directly (which uses a Gradle config instead of jUnit), 4 are skipped and 1 fails withAssertionFailedError
In both cases, the
AssertionFailedError
was present already in the master (didn't run all tests on the master, only the ones failed in the branch). Additionally, several tests in the branch were ignored by IDEA.