Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow up/download table CSV by name or id #3544

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Mar 22, 2024

Following request of @YpeZ, uploading a CSV file for one table when having spaces in the name it fails:

image

In current version for some reason we assume CSV and Excel up/downloads to use the 'id' of the table.
That is silly because we typically upload the csv files from a data.zip and then those use 'name' of the table
So this feature makes it possible to use both 'name' and 'id' (with us prefering to use the 'name').

how to test:

  • upload table like 'Collection events.csv' and 'CollectionEvents.csv' should both work
  • discussion: make it case insensitive too?

@mswertz mswertz added this to the Catalogue 218 milestone Mar 23, 2024
@mswertz mswertz changed the title feat: allow download table by name or id feat: allow up/download table by name or id Mar 23, 2024
@mswertz mswertz requested a review from YpeZ March 23, 2024 16:11
@mswertz mswertz modified the milestones: Catalogue 218, Catalogue 219 Mar 25, 2024
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test:
1.) The preview has an issue with the theme.css. I've also rebuild the PR, but issue is still there. I'm not sure if this is caused by the changes in the PR or due to something else.
2.) I've tested several options:
image

In all cases uploading excel/zip or csv with tableName works OK now. However, I'm not able to upload any type of file with the tableID as name, which should be the case as the title of the PR indicates, or am I wrong?

tablename and tableid are table1 and Table1 respectively

@mswertz
Copy link
Member Author

mswertz commented Apr 3, 2024

this PR didn't yet consider Excel, only csv. But the errors you report there are indeed correct. Will update title to make clear it is about the csv,

@mswertz mswertz changed the title feat: allow up/download table by name or id feat: allow up/download table CSV by name or id Apr 3, 2024
Copy link

sonarcloud bot commented Apr 3, 2024

@mswertz mswertz marked this pull request as draft April 5, 2024 07:52
Copy link

sonarcloud bot commented May 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants