-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow up/download table CSV by name or id #3544
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test:
1.) The preview has an issue with the theme.css. I've also rebuild the PR, but issue is still there. I'm not sure if this is caused by the changes in the PR or due to something else.
2.) I've tested several options:
In all cases uploading excel/zip or csv with tableName works OK now. However, I'm not able to upload any type of file with the tableID as name, which should be the case as the title of the PR indicates, or am I wrong?
tablename and tableid are table1 and Table1 respectively
this PR didn't yet consider Excel, only csv. But the errors you report there are indeed correct. Will update title to make clear it is about the csv, |
Quality Gate passedIssues Measures |
Quality Gate passedIssues Measures |
Following request of @YpeZ, uploading a CSV file for one table when having spaces in the name it fails:
In current version for some reason we assume CSV and Excel up/downloads to use the 'id' of the table.
That is silly because we typically upload the csv files from a data.zip and then those use 'name' of the table
So this feature makes it possible to use both 'name' and 'id' (with us prefering to use the 'name').
how to test: