Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When searching for a variable which has repeated measurements, clearer information should be provided on the 'list of variables' tab #3484

Closed
timcadman opened this issue Mar 11, 2024 · 9 comments
Assignees
Labels
priority Features/bugs that we should not let wait ssr-catalogue ssr-pretest
Milestone

Comments

@timcadman
Copy link
Contributor

timcadman commented Mar 11, 2024

Decision: show (+ 12)

Is your feature request related to a problem? Please describe.
When searching for a variable which has repeated measurements, in the 'list of variables' tab, only the first variable is returned. This can leave it confusing for a researcher unfamiliar with the catalogue whether data exists at additional ages, or whether this is the only variable that exists.

Describe the solution you'd like
For me it would be more intuitive if only the stem of the variable was displayed (e.g. "adhd_wave_", rather than "adhd_wave_1"), and potentially an additional element to the right stating 'repeated measurements'.

Describe alternatives you've considered
Make no changes and leave it for the researcher to discover this when clicking on the variable.

Additional context
Captura de pantalla 2024-03-11 a las 11 35 33 (2)

@timcadman timcadman changed the title When searching for a variable which has repeated measurements, clearer information should be provided on the 'list of variables 'tab When searching for a variable which has repeated measurements, clearer information should be provided on the 'list of variables' tab Mar 11, 2024
@marijevdgeest
Copy link
Contributor

First suggestion is related to the root variables (https://trac.molgeniscloud.org/ticket/10410) - requires data edit not software update.

I agree to look into info about repeats. Maybe label + nr of repeats available?

@timcadman
Copy link
Contributor Author

Yes something simple just saying "x more repeats available" would be good

@timcadman
Copy link
Contributor Author

Something like this:

Captura de pantalla 2024-03-13 a las 13 57 16

@EleanorHyde-UMCG EleanorHyde-UMCG modified the milestone: Catalogue 219 Apr 2, 2024
@EleanorHyde-UMCG
Copy link
Contributor

EleanorHyde-UMCG commented Apr 2, 2024

Request from Morris: add a plus on the LHS of repeated variables, which you can then expand to show the repeated variables underneath. This is how it looks in Lifelines:

image

@marijevdgeest
Copy link
Contributor

I think this solution has a different purpose in the Lifelines cat, here the repeats show actual additional information, while for the data catalogue it's just a list of names where only the numbers are different from the root variable, so this solution seems to take up a lot of space that's not necessary. I think showing something simpler is already enough information ("+ x repeats") and much more clean.

@EleanorHyde-UMCG
Copy link
Contributor

I think this solution has a different purpose in the Lifelines cat, here the repeats show actual additional information, while for the data catalogue it's just a list of names where only the numbers are different from the root variable, so this solution seems to take up a lot of space that's not necessary. I think showing something simpler is already enough information ("+ x repeats") and much more clean.

@marijevdgeest could you make a mock-up please of how you see this?

@marijevdgeest
Copy link
Contributor

I think this solution has a different purpose in the Lifelines cat, here the repeats show actual additional information, while for the data catalogue it's just a list of names where only the numbers are different from the root variable, so this solution seems to take up a lot of space that's not necessary. I think showing something simpler is already enough information ("+ x repeats") and much more clean.

@marijevdgeest could you make a mock-up please of how you see this?

I'm actually not sure what would be the best option, everything feels quite clunky. I was thinking maybe just a number after the variable name and no number when there are no repeats. Like:
VariablenameA_ (12)
VariablenameB
VariablenameC_ (21)

But not sure if that would be clear enough. @timcadman what do you think?

@timcadman
Copy link
Contributor Author

timcadman commented Apr 12, 2024

Perhaps either
(+ 12) or (+ 12 repeats) would be clearer?

Or if just (12) could we add a key/legend explaining what this means?

@esthervanenckevort esthervanenckevort added this to the Inbox milestone Apr 19, 2024
@esthervanenckevort esthervanenckevort modified the milestones: Inbox, Sprint 221 May 3, 2024
@mswertz mswertz added the priority Features/bugs that we should not let wait label May 6, 2024
@chinook25
Copy link
Contributor

Once it's clear what we want, can the original issue be updated with that information?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Features/bugs that we should not let wait ssr-catalogue ssr-pretest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants