Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop previous apolloServer before creating a new one #91

Merged
merged 3 commits into from Mar 21, 2021

Conversation

arash16
Copy link
Contributor

@arash16 arash16 commented Mar 8, 2021

This causes socket listeners to close gracefully.
Fixes issues #51 and #74

This causes socket listeners to close gracefully.
Fixes issues moleculerjs#51 and moleculerjs#74
src/service.js Outdated Show resolved Hide resolved
@shawnmcknight
Copy link
Member

@arash16 CI is currently failing. Tests need to be updated to handle your changes.

@shawnmcknight
Copy link
Member

I've updated the tests so they are no longer failing.
@Hugome or @icebob Would you mind giving this a review? Everything looks good to me now.

Copy link
Collaborator

@Hugome Hugome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't try it now, but the code looks good to me, too.

@icebob icebob merged commit f80ac10 into moleculerjs:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants