Skip to content

Commit

Permalink
Support update service which contains serviceRegistries (pipe-cd#4567)
Browse files Browse the repository at this point in the history
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Signed-off-by: moko-poi <mokopoi44@gmail.com>
  • Loading branch information
khanhtc1202 authored and moko-poi committed Nov 3, 2023
1 parent 82e5889 commit 9412c71
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/app/piped/platformprovider/ecs/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,8 +135,10 @@ func (c *client) UpdateService(ctx context.Context, service types.Service) (*typ
// Hack: Since we use EXTERNAL deployment controller, the below configurations are not allowed to be passed
// in UpdateService step, but it required in further step (CreateTaskSet step). We reassign those values
// as part of service definition for that purpose.
// ref: https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_CreateService.html
output.Service.LaunchType = service.LaunchType
output.Service.NetworkConfiguration = service.NetworkConfiguration
output.Service.ServiceRegistries = service.ServiceRegistries

return output.Service, nil
}
Expand Down

0 comments on commit 9412c71

Please sign in to comment.