Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Enable Miri tests on moka::cht::* modules #280

Open
tatsuya6502 opened this issue Jun 17, 2023 · 0 comments
Open

CI: Enable Miri tests on moka::cht::* modules #280

tatsuya6502 opened this issue Jun 17, 2023 · 0 comments

Comments

@tatsuya6502
Copy link
Member

tatsuya6502 commented Jun 17, 2023

Split from #279.

Currently, we run miri test on the CI only on the deque and timer_wheel modules under moka::common: .github/workflows/Miri.yml#L43-L53

Enable miri test on moka::cht::* modules as well.

To do it, we need to shrink the test size (number of MIR statements to execute) when testing with Miri. For example, the following single test took ~4 hours (231 minutes) on my M1 Mac:

$ time cargo +nightly miri test --lib cht::segment::tests::insertion
...
running 1 test
test cht::segment::tests::insertion ... 
...
ok  

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 90 filtered out
...

________________________________________________________
Executed in  231.55 mins    fish           external
   usr time   90.31 mins    0.36 millis   90.31 mins
   sys time   89.41 mins    2.50 millis   89.41 mins

There are more than 20 tests under these modules.

@tatsuya6502 tatsuya6502 changed the title CI: Enable Miri tests on moka::cht modules CI: Enable Miri tests on moka::cht::* modules Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant