Fixed the Cookbook systemd unit to use Environment= for NODE_ENV #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerodogg
changed the title
|
The commit message has a typo. |
zerodogg
force-pushed
the
fix-cookbook-systemd-unit
branch
from
7396d2f
to
52580e8
Compare
|
Force pushed an update |
kraih
previously approved these changes
Apr 25, 2024
ExecStart is not run with /bin/sh, so setting NODE_ENV there doesn't work and results in: Failed at step EXEC spawning NODE_ENV=production: No such file or directory. Setting NODE_ENV in an Environment="" fixes this.
zerodogg
force-pushed
the
fix-cookbook-systemd-unit
branch
from
52580e8
to
ba5c49e
Compare
|
Sorry, updated it again. I noticed that there was another ExecStart a bit further down in the document that also had the NODE_ENV=.. syntax. |
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExecStart is not run with /bin/sh, so setting NODE_ENV there doesn't work and results in: Failed at step EXEC spawning NODE_ENV=production: No such file or directory.
Setting NODE_ENV in an Environment="" fixes this.