Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#858 Fix child module resolution for multi-level projects #859

Merged
merged 1 commit into from Dec 16, 2022
Merged

#858 Fix child module resolution for multi-level projects #859

merged 1 commit into from Dec 16, 2022

Conversation

corebonts
Copy link

Child modules were processed in a parallel stream which added elements to an unsynchonized LinkedHashMap.

This may resulted an incomplete set of child modules.

@jarmoniuk
Copy link
Contributor

@corebonts please also modify https://github.com/mojohaus/versions/blob/master/versions-maven-plugin/src/main/java/org/codehaus/mojo/versions/SetMojo.java#L375

mojohaus#858 Fix module resolution for multi-level projects
e4ee3be 
Modules were processed in a parallel stream which added elements to
an unsynchonized LinkedHashMap / LinkedHashSet.

This may resulted an incomplete set of child modules.

Note that as the stream items are not processed heavily there is no or minor
advantage of parallel processing.
@jarmoniuk
Copy link
Contributor

Closed my own PR fixing this. @slachiewicz @slawekjaranowski could you please approve the run? Thanks

@slawekjaranowski slawekjaranowski linked an issue Dec 16, 2022 that may be closed by this pull request
Versions Maven Plugin updates random Module subsets with 2.14.1 #858
Closed
@slawekjaranowski slawekjaranowski added this to the next-release milestone Dec 16, 2022
@slawekjaranowski
Copy link
Member

slawekjaranowski commented Dec 16, 2022 •
edited

I also see that parallelStream is used in many other places

I don't see a much performance benefit of used it but can cause a problem like here.
Maybe we simply can replace all occurrences.

Can be done is next PR 😄

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Dec 16, 2022 •
edited

Went other these during the evaluation of this one. Basically a problem occurs when there is a modification of a non-thread safe collection during stream execution. There should be no problem with the creation of a new collection, which is the case in all other places than the corrected in this PR.

Having said that, replacing that with a simple stream would be a conservative take and definitely on the safe side. Experience shows that I can be wrong :)

@corebonts
Copy link
Author

After Andrzej told me about the other problematic class, I also went through all the other usages and I can confirm that the others are ok for now. But I neither see a big performance benefit of using parallel streams.

@slawekjaranowski slawekjaranowski merged commit 6619919 into mojohaus:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slachiewicz slachiewicz slachiewicz approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.14.2
Development

Successfully merging this pull request may close these issues.

Versions Maven Plugin updates random Module subsets with 2.14.1
4 participants
@corebonts @jarmoniuk @slawekjaranowski @slachiewicz