Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#333: aggregated reports #836

Merged
merged 1 commit into from Dec 4, 2022
Merged

#333: aggregated reports #836

merged 1 commit into from Dec 4, 2022

Conversation

MihaStemberger
Copy link

Hello, here is my shot at trying to solve #333

@MihaStemberger MihaStemberger changed the title Feature/333 aggregated reports #333: aggregated reports Nov 30, 2022
@jarmoniuk
Copy link
Contributor

@slachiewicz or @slawekjaranowski can you approve the flow please? Thanks!

@slawekjaranowski
Copy link
Member

For new files we use standard Apache 2.0 license headers:
https://groups.google.com/g/mojohaus-dev/c/OTg7XfiX61w

I prefer groovy scripts for verification than beanshell ... as nice to have 😄

@MihaStemberger
Copy link
Author

For new files we use standard Apache 2.0 license headers: https://groups.google.com/g/mojohaus-dev/c/OTg7XfiX61w

I prefer groovy scripts for verification than beanshell ... as nice to have smile

Added Apache 2.0 license headers to newly added *.java files, replaced beanshell verification scripts with groovy scripts

slawekjaranowski
slawekjaranowski reviewed Dec 3, 2022
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last nits

...ven-plugin/src/main/java/org/codehaus/mojo/versions/AbstractDependencyUpdatesReportMojo.java Outdated Show resolved Hide resolved
...s-maven-plugin/src/main/java/org/codehaus/mojo/versions/AbstractPluginUpdatesReportMojo.java Outdated Show resolved Hide resolved
...maven-plugin/src/main/java/org/codehaus/mojo/versions/AbstractPropertyUpdatesReportMojo.java Outdated Show resolved Hide resolved
...-maven-plugin/src/main/java/org/codehaus/mojo/versions/PluginUpdatesAggregateReportMojo.java Outdated Show resolved Hide resolved
Fixed #333
17b20cc 
  aggregated reports
@MihaStemberger
Copy link
Author

last nits

Resolved

@slawekjaranowski slawekjaranowski linked an issue Dec 3, 2022 that may be closed by this pull request
aggregate reports support #333
Closed
@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Dec 3, 2022
@slawekjaranowski slawekjaranowski merged commit 112e9ee into mojohaus:master Dec 4, 2022
@MihaStemberger
Copy link
Author

I forgot to ask. Is there something to add, for added aggregate report goals to be visible under https://www.mojohaus.org/versions-maven-plugin/#reporting-goals-overview ?

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Dec 5, 2022 •
edited

Yes, you're supposed to have edited https://github.com/mojohaus/versions-maven-plugin/blob/master/versions-maven-plugin/src/site/markdown/index.md

But I guess you can still do it in another PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarmoniuk jarmoniuk jarmoniuk requested changes

@slawekjaranowski slawekjaranowski slawekjaranowski left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.14.0
Development

Successfully merging this pull request may close these issues.

aggregate reports support
3 participants
@MihaStemberger @jarmoniuk @slawekjaranowski