Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#704: Remove remaining ArtifactRepository leftovers + use version range for VersionsHelper where applicable #833

Merged
merged 1 commit into from Dec 4, 2022

Conversation

jarmoniuk
Copy link
Contributor

Utilising the fact that we can pass the versionRange directly to RepositorySystem.resolveVersionRange, which should optimise the search process (possibly less lookups performed).

Also, removing the unused findLatestVersion( Artifact, VersionRange, Boolean, boolean ) method.

@jarmoniuk jarmoniuk changed the title Utilise version range for VersionsHelper where applicable #704: Remove remaining ArtifactRepository leftovers + use version range for VersionsHelper where applicable Nov 30, 2022
@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Nov 30, 2022

I've noticed that there are still some ArtifactRepository leftovers left. Removed those.

Also, Maven 3 version range resolver allows version range resolving -- using that to speed up version resolution a bit.

Small refactoring/cleanup, especially in DisplayPluginUpdates.

Oh and by the way -- as you can probably see, there are still some parts where we are accounting for Maven 2. Should we remove that? If so, I'll do that in another PR, because that would involve also removing some of the IT's.

@slawekjaranowski please check

@jarmoniuk jarmoniuk force-pushed the utilise-version-range branch 2 times, most recently from e63eab1 to 1752976 Compare December 2, 2022 19:45
@jarmoniuk jarmoniuk force-pushed the utilise-version-range branch 2 times, most recently from 24f0be6 to a4b99bf Compare December 3, 2022 18:24
@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Dec 3, 2022

@slawekjaranowski

As advised in https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies

Remove maven-compat (or give it the test-scope if it is required by the maven-plugin-testing-harness)

@jarmoniuk
Copy link
Contributor Author

I guess I can move to PlexusJunit4TestCase in another PR.

Comment on lines 11 to 13
<prerequisites>
<maven>2.0.6</maven>
<maven>3.2.5</maven>
</prerequisites>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prerequisites is only used for maven-plugin packaging.

Comment on lines -445 to +401
version );
version );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I start thinking to introduce spotless as is done in Maven from parent poms 38 when we have such line changed 😄

@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Dec 4, 2022
@slawekjaranowski slawekjaranowski merged commit 635b310 into mojohaus:master Dec 4, 2022
@jarmoniuk jarmoniuk deleted the utilise-version-range branch December 4, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants