Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make includeParent false by default to retain backward compatibility. #817

Merged
merged 1 commit into from Nov 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -131,11 +131,11 @@ public class DisplayPropertyUpdatesMojo
private boolean allowIncrementalUpdates;

/**
* <p>Whether to include property updates from parent.</p>
* <p>Whether to include property updates from parent. Default: {@code false}</p>
*
* @since 2.14.0
*/
@Parameter( property = "includeParent", defaultValue = "true" )
@Parameter( property = "includeParent", defaultValue = "false" )
protected boolean includeParent = true;

// -------------------------- STATIC METHODS --------------------------
Expand Down
Expand Up @@ -92,11 +92,11 @@ public class PropertyUpdatesReportMojo extends AbstractVersionsReport<PropertyUp
private boolean autoLinkItems;

/**
* <p>Whether to include property updates from parent.</p>
* <p>Whether to include property updates from parent. Default: {@code false}</p>
*
* @since 2.14.0
*/
@Parameter( property = "includeParent", defaultValue = "true" )
@Parameter( property = "includeParent", defaultValue = "false" )
private boolean includeParent = true;

/**
Expand Down
Expand Up @@ -81,6 +81,7 @@ public void testPropertiesFromParent() throws Exception
mojo.outputFile = tempFile.toFile();
mojo.setPluginContext( new HashMap<>() );
mojo.artifactMetadataSource = MockUtils.mockArtifactMetadataSource();
mojo.includeParent = true;
mojo.execute();

assertThat( String.join( "", Files.readAllLines( tempFile ) ),
Expand Down