Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #505: getReactorModels using correct module paths when the module name includes pom.xml #805

Merged

Conversation

jarmoniuk
Copy link
Contributor

Nothing fancy or spectacular, just a simple bug fix for the edge case of having the module name include the pom.xml file path. In the unpatched implementation, the "/pom.xml" was treated as part of the directory name when descending down the module tree to retrieve child models... Fixed that.

Added some tests (unit test for the PomHelper method + integration test for the use case from the issue).

@slawekjaranowski please review

@jarmoniuk
Copy link
Contributor Author

getProjectParent( final ModifiedPomXMLEventReader pom, VersionsHelper helper ) and removeMissingChildModules( Log logger, MavenProject project, Collection<String> childModules ) were no longer used -> removed

@jarmoniuk jarmoniuk force-pushed the issue-505-modules-paths branch 2 times, most recently from 8981bc0 to a406bb2 Compare November 3, 2022 05:49
@jarmoniuk
Copy link
Contributor Author

Rebased.

@slawekjaranowski slawekjaranowski added this to the 2.14.0 milestone Nov 3, 2022
@slawekjaranowski slawekjaranowski linked an issue Nov 3, 2022 that may be closed by this pull request
@slawekjaranowski slawekjaranowski merged commit 96deb8e into mojohaus:master Nov 3, 2022
@jarmoniuk jarmoniuk deleted the issue-505-modules-paths branch November 3, 2022 18:37
@rshkv
Copy link

rshkv commented Dec 14, 2022

I think there might have been a break here: versions:set stopped working in my repo and I narrowed it down to this commit. I'm attaching --debug logs for a run with this commit and a run on 2.13.0.

versions-set-output-2.13.0.txt
versions-set-output-805.txt

@slawekjaranowski
Copy link
Member

please follow #848 #849

@jarmoniuk
Copy link
Contributor Author

@rshkv thanks. Tested this with the PR, problem looks solved.

@rshkv
Copy link

rshkv commented Dec 14, 2022

Thank you for the reply guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin cannot update child versions when pom path specified
3 participants