Resolves #359: XML Property Updates Report

[jarmoniuk]

XML version of the Property Updates Report

@slawekjaranowski please review

[jarmoniuk]

Failing with JVM 8 during compilation because of incompatible types:

java.util.Map cannot be assigned to a java.util.Map argument.

Strange. I've reproduced it with coretto-1.8

    org/codehaus/mojo/versions/xml/PropertyUpdatesXmlReportRenderer.createPropertyInfo(Ljava/util/Map;)Ljava/util/List; @12: invokedynamic
  Reason:
    Type 'java/util/Map' (current frame, stack[1]) is not assignable to 'org/codehaus/mojo/versions/xml/PropertyUpdatesXmlReportRenderer'
  Current Frame:
    bci: @12
    flags: { }
    locals: { 'java/util/Map' }
    stack: { 'java/util/stream/Stream', 'java/util/Map' }
  Bytecode:
    0x0000000: 2ab9 0016 0100 b900 1701 002a ba00 1800
    0x0000010: 00b9 0019 0200 b800 1ab9 001b 0200 c000
    0x0000020: 1cb0                                  

The error is gone if I make the method non-static.

Looks like a javac bug.

As I suspected the error has something to do with the inferred type of the List built with Collections.toList() so, not the reported Map incompatibility, but another one (because it's not PropertyAssociation, but its child type), I changed the way how the object is constructed and it worked fine; it also worked fine if I used

() -> new ArrayList<PropertyAssociation>() with the collect method. However, that the problem was gone when I changed the method to non-static suggests a compiler bug.

Anyway, the thing is resolved now -- I made the assigned list return a list of the actual PropertyAssociation. However, this fix has nothing to do with the reported java.util.Map incompatibitilty.

[sultan]

i also had class cast ex, during report rendering, between classes like Map.Node and Map.TreeNode. i'll open an issue if i can reproduce