Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New feature (#477): connection, developerConnection, url arguments for set-scm-tag #664

Merged
merged 1 commit into from Aug 31, 2022
Merged

New feature (#477): connection, developerConnection, url arguments for set-scm-tag #664

merged 1 commit into from Aug 31, 2022

Conversation

jarmoniuk
Copy link
Contributor

Adding the requested new features and modifying the first it for the feature.

@slawekjaranowski
Copy link
Member

newTag parameter is still required, we should require one of allowed parameters

@jarmoniuk
Copy link
Contributor Author

newTag parameter is still required, we should require one of allowed parameters

Done.

@jarmoniuk jarmoniuk force-pushed the issue-477-scm-new-features branch 4 times, most recently from f548113 to 1ea99a6 Compare August 31, 2022 19:24
@jarmoniuk
Copy link
Contributor Author

jarmoniuk commented Aug 31, 2022 •
edited

Reverted to the original version of the PR (rather than one manipulating on and saving a MavenModel): this version retains the original structure of POM.

Corrected one found issue: newTag would always be applied regardless of being defined or not.

@jarmoniuk jarmoniuk force-pushed the issue-477-scm-new-features branch 3 times, most recently from 6e29659 to a784244 Compare August 31, 2022 20:42
@slawekjaranowski slawekjaranowski linked an issue Aug 31, 2022 that may be closed by this pull request
Update the <connection>, <developerConnection> and <url> sections inside <scm> #477
Closed
@slawekjaranowski slawekjaranowski merged commit 52cd445 into mojohaus:master Aug 31, 2022
@jarmoniuk jarmoniuk deleted the issue-477-scm-new-features branch September 1, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the <connection>, <developerConnection> and <url> sections inside <scm>
2 participants
@jarmoniuk @slawekjaranowski