Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #318: versions:display-dependency-updates goal need to have exc… #350

Closed
wants to merge 1 commit into from
Closed

Conversation

HonoluluHenk
Copy link

…ludes and includes property

@HonoluluHenk
Copy link
Author

I'd be happy to implement some tests if the implemented solution is viable

@aegliv
Copy link

aegliv commented Jul 28, 2020

I would love to see this PR merged. What is still missing?

@tfactor2
Copy link

No progress so far? For us it would be also very useful - we have a set of internal libraries and would like to keep the teams up-to-date with the newest library versions but don't want to check version updates for a full framework like Spring Boot.

@HonoluluHenk
Copy link
Author

@stephenc care to comment or close as won't fix?

@stephenc
Copy link
Contributor

I think others have been maintaining this plugin for a while now. Tbh my focus is not in a place where I can give this the care it needs. Try the last person to cut a release

@HonoluluHenk
Copy link
Author

@mfriedenhagen care to comment or close as won't fix?

@tfactor2
Copy link

Still extremely relevant.
I saw the last commit from @mfriedenhagen - probably you can clarify the situation and make a decision about the issue?

Thx in advance.

@github-actions
Copy link

This PR is stale because it has been open 365 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the Stale label Mar 31, 2022
@HonoluluHenk
Copy link
Author

bump

@stefanseifert
Copy link
Contributor

i can support this PR and help getting it merged and released.

some open issues/questions/remarks:

  • this issue does not implement what the title and versions:display-dependency-updates goal need to have excludes and includes property #318 suggests (=adding includes/excludes to display-dependency-updates properties as in use-latest-versions). instead, it adds a possibility to filter for scopes in dependency and dependencyManagement section. this is also useful, but a different issue and PR should be created.
  • this PR has merge conflicts - can you rebase or merge it with current master?
  • we also need an integration test for the new behavior

@fmdaboville
Copy link

@HonoluluHenk any news about the merge for this feature ?

@HonoluluHenk
Copy link
Author

I just started a new PR addressing all of the issues mentioned by stefanseifert...

@HonoluluHenk
Copy link
Author

closed because it is deprecated,

@stefanseifert Could you instead review PR #602 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants