Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #682: Restoring the ability to provide an empty "newVersion" argument #683

Conversation

jarmoniuk
Copy link
Contributor

Looks like folks were using the ability to clear a property value. Restoring it + updating the unit test suite.

@jarmoniuk jarmoniuk force-pushed the issue-682-set-property-allow-null-version branch from e654b41 to 28cee94 Compare September 9, 2022 05:09
@jarmoniuk
Copy link
Contributor Author

@slawekjaranowski please review

@jarmoniuk jarmoniuk force-pushed the issue-682-set-property-allow-null-version branch from 28cee94 to 0c034a3 Compare September 9, 2022 08:36
@jarmoniuk
Copy link
Contributor Author

Could you restart the jobs?

@slawekjaranowski slawekjaranowski added this to the next-release milestone Sep 12, 2022
@slawekjaranowski slawekjaranowski linked an issue Sep 12, 2022 that may be closed by this pull request
@slawekjaranowski slawekjaranowski merged commit fb89924 into mojohaus:master Sep 12, 2022
@jarmoniuk jarmoniuk deleted the issue-682-set-property-allow-null-version branch September 12, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: set-property should allow clearing properties
2 participants