Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: set-property should allow clearing properties #682

Closed
jarmoniuk opened this issue Sep 8, 2022 · 0 comments · Fixed by #683
Closed

Regression: set-property should allow clearing properties #682

jarmoniuk opened this issue Sep 8, 2022 · 0 comments · Fixed by #683
Labels
bug
Milestone
2.13.0

Comments

@jarmoniuk
Copy link
Contributor

jarmoniuk commented Sep 8, 2022 •
edited

As indicated in the comments to the PR #667, set-property should allow setting an empty version value to properties.

The NPE coming from ModifiedXMLEventReader is easy to fix. I'll do it tomorrow.
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Sep 9, 2022
@jarmoniuk
Fixed mojohaus#682: Restoring the ability to provide an empty "newVer…
e654b41 
…sion" argument
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Sep 9, 2022
@jarmoniuk
Fixed mojohaus#682: Restoring the ability to provide an empty "newVer…
28cee94 
…sion" argument
jarmoniuk added a commit to jarmoniuk/versions-maven-plugin that referenced this issue Sep 9, 2022
@jarmoniuk
Fixed mojohaus#682: Restoring the ability to provide an empty "newVer…
0c034a3 
…sion" argument
@slawekjaranowski slawekjaranowski linked a pull request Sep 12, 2022 that will close this issue
Fixed #682: Restoring the ability to provide an empty "newVersion" argument #683
Merged
slawekjaranowski pushed a commit that referenced this issue Sep 12, 2022
@jarmoniuk @slawekjaranowski
Fixed #682: Restoring the ability to provide an empty "newVersion" ar…
fb89924 
…gument
@slawekjaranowski slawekjaranowski added this to the next-release milestone Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.13.0
2 participants
@jarmoniuk @slawekjaranowski