New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/337 slf4j logging #339
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @digulla , comments inline.
src/main/java/org/codehaus/mojo/license/AbstractAddThirdPartyMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/AbstractAddThirdPartyMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/AggregatorAddThirdPartyMojo.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/download/PreferredFileNames.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/mojo/license/header/UpdateFileHeaderFilter.java
Show resolved
Hide resolved
… same version is used in the whole dependency tree. All versions should be here but I don't want to change too much.
…G.debug() without the guard here.
…oaded missing file ...".
Use missingFile over "missing file" to avoid confusion. Got rid of verbose flag in getProjectsWithNoLicense()
…d problems, moved to our dependencyManagement element so everyone will use our preferred version.
The last two commits fix a deprecation and a warning I got in the POM. Since they are small changes, I didn't want to create a PR for them. |
Summary: two last things open from my PoV:
|
I'm now running out of time. I'll be at a conference next week, see you in July. |
@digulla it is a pitty. This is not the first time that reviewing your large PR costs me time with no result. Please send PRs that have chance to get reviewed and merged quickly. Please discuss potentially controversial things like adding new dependencies upfront. To move forward with the next release, unless you veto within a reasonable time, I am going to make a new PR out of the acceptable parts of this PR. |
Replaced by #342 |
Notes:
if (LOG.is...Level())
if (LOG.is...Level())
is it protected a big code block."..." + variable
with"... {}", variable
in all places I noticed. This should now be the default."... +" Arrays.asList(x)
wherex
is an array with"{}", (Object)x
. Without the case, the Java compiler would try to copy the array elements into the varargs parameter of slf4j with the result that only the first element of the array would be logged.