Fix #100 Set project.originalModel after flattening
#281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@slachiewicz I know you may be busy, but do you have initial thoughts on this PR? |
|
@slachiewicz any update on this? |
|
@slachiewicz more ping. If you're busy, or not much involved any more, can you recommend someone else who might review? |
slachiewicz
approved these changes
Jul 11, 2022
|
Please squash to one final commit |
slawekjaranowski
requested changes
Aug 7, 2022
README.md
Outdated
|
|
||
| - When developing new integration test cases an easy way to only run the scenario you are working on is to create a new | ||
| directory (e.g. `src/it/new-case`) and put your new `pom.xml` and `verify.groovy` in that directory. Then update the | ||
| `<projectsDirectory>` path of the `run-its` profile to point to the directory containing your single test case. |
There was a problem hiding this comment.
We can use: invoker.test property
mvn verify -P run-its -Dinvoker.test=<projectsDirectory>
slawekjaranowski
force-pushed
the
maven-shade-compat
branch
from
d3469c8
to
1fbf0c2
Compare
Based on the discussion in maven-shade-plugin#129 apache/maven-shade-plugin#129 (comment) It seems that the flatten plugin should update the `originalModel` property after we flatten the pom.
slawekjaranowski
force-pushed
the
maven-shade-compat
branch
from
1fbf0c2
to
971ae28
Compare
slawekjaranowski
approved these changes
Aug 15, 2022
|
Thanks for fixing this issue! :-) |
slawekjaranowski
changed the title
project.originalModel after flatteningproject.originalModel after flattening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in apache/maven-shade-plugin#129 (comment) It seems that the flatten plugin should update the
originalModelproperty after we flatten the pom.This issue resolves #100 and is an alternate way to close #279