Bump flatten-maven-plugin to 1.3.0
#1187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ederign
approved these changes
Aug 17, 2022
|
Thanks a lot @slawekjaranowski |
|
Works as a charm, thank you @slawekjaranowski and @tiagobento! |
hasys
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue first reported by @hasys, where he could not run
mvn gwt:runonpackages/serverless-workflow-diagram-editor/sw-editor/sw-editor-kogito-app.We found out this issue was a bug (mojohaus/flatten-maven-plugin#100) on
flatten-maven-plugin, which was clashing withshade-maven-plugin, leaving the installed POM with a reference to the CI friendly version${revision}.We contacted the maintainers of
flatten-maven-pluginthrough this issue mojohaus/flatten-maven-plugin#292 and they kindly released a new version containing the fix (mojohaus/flatten-maven-plugin#281) right away. (Thanks a lot, @slawekjaranowski 馃帀)