Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#81 IllegalArgumentException when using goal released-version with maven 3.6.2/3.6.3 #88

Merged
merged 2 commits into from Feb 18, 2020
Merged

#81 IllegalArgumentException when using goal released-version with maven 3.6.2/3.6.3 #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
920636f
#81 add integration test to execute released-version goal
stefanseifert Feb 14, 2020
ccbfb61
Fix issue #81
Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/it/released-version/invoker.properties
View file
Open in desktop
@@ -0,0 +1,2 @@
invoker.goals = test
invoker.buildResult = success
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a bit picky, but usually files end with a EOL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copied it over from the other ITs, it's the same there
i think this is really cosmetic...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. You might laugh, but when I tried to contribute to the Maven checkstyle plugin, those things are mentioned as well. 😅
Anyway, this does not block anything, just wanted to let you know. LGTM.

64 changes: 64 additions & 0 deletions src/it/released-version/pom.xml
View file
Open in desktop
@@ -0,0 +1,64 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin-released-version-it</artifactId>
<version>1.0-SNAPSHOT</version>
<name>build-helper-maven-plugin-released-version-it</name>

<build>
<defaultGoal>package</defaultGoal>
<plugins>
<plugin>
<groupId>@project.groupId@</groupId>
<artifactId>@project.artifactId@</artifactId>
<version>@project.version@</version>
<executions>
<execution>
<id>released-version</id>
<goals>
<goal>released-version</goal>
</goals>
<configuration>
<propertyPrefix>myReleasedVersion</propertyPrefix>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<artifactId>maven-antrun-plugin</artifactId>
<executions>
<execution>
<id>mk-target-dir</id>
<phase>compile</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<tasks>
<mkdir dir="${project.build.directory}" />
</tasks>
</configuration>
</execution>

<execution>
<id>echo-released-version</id>
<phase>test</phase>
<goals>
<goal>run</goal>
</goals>
<configuration>
<tasks>
<echo>myReleasedVersion.version=${myReleasedVersion.version}</echo>
<echo>myReleasedVersion.majorVersion=${myReleasedVersion.majorVersion}</echo>
<echo>myReleasedVersion.minorVersion=${myReleasedVersion.minorVersion}</echo>
<echo>myReleasedVersion.incrementalVersion=${myReleasedVersion.incrementalVersion}</echo>
</tasks>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>

</project>
9 changes: 9 additions & 0 deletions src/it/released-version/verify.groovy
View file
Open in desktop
@@ -0,0 +1,9 @@
File file = new File( basedir, "build.log" );
assert file.exists();

String text = file.getText("utf-8");

// its difficult to check the positove case with an existing released version in an IT - so currently we test only the case when no version is detected
assert text.contains("No released version found.")

return true;
5 changes: 4 additions & 1 deletion src/main/java/org/codehaus/mojo/buildhelper/ReleasedVersionMojo.java
View file
Open in desktop
Expand Up @@ -92,7 +92,7 @@ private void defineVersionProperty( String name, int value )
public void execute()
{
org.apache.maven.artifact.Artifact artifact =
artifactFactory.createArtifact( getProject().getGroupId(), getProject().getArtifactId(), "", "", "" );
artifactFactory.createArtifact( getProject().getGroupId(), getProject().getArtifactId(), getProject().getVersion(), "", "" );
try
{
ArtifactVersion releasedVersion = null;
Expand Down Expand Up @@ -127,6 +127,9 @@ public void execute()
defineVersionProperty( "buildNumber", releasedVersion.getBuildNumber() );
defineVersionProperty( "qualifier", releasedVersion.getQualifier() );
}
else {
getLog().debug("No released version found.");
}

}
catch ( ArtifactMetadataRetrievalException e )
Expand Down