Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues #80 and #81 #82

Closed
wants to merge 2 commits into from
Closed

Fix issues #80 and #81 #82

wants to merge 2 commits into from

Conversation

veikokaap
Copy link

No description provided.

@veikokaap veikokaap mentioned this pull request Nov 10, 2019
Closed
@stefanseifert stefanseifert self-assigned this Feb 14, 2020
@stefanseifert stefanseifert mentioned this pull request Feb 14, 2020
Merged
@stefanseifert
Copy link
Collaborator

thanks for the PR - i've created a new PR #88 dedicated to #81 and cherry-picked your fix to this new branch, together with an integration test

@stefanseifert
Copy link
Collaborator

i've created a new PR #89 for #80 with a subtle different implementation (checking all props, using empty string for null instead of "null")

setting this PR to closed as it is superseded by #88 and #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanseifert stefanseifert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@veikokaap @stefanseifert