Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes & Updates for latest dependencies #38

Merged
merged 4 commits into from Sep 16, 2019
Merged

Fixes & Updates for latest dependencies #38

merged 4 commits into from Sep 16, 2019

Conversation

mdebarros
Copy link
Member

@mdebarros mdebarros commented Sep 16, 2019 •
edited

Dependency updates:

  • Fixes for the latest version of async which introduced a breaking change --> BREAKING CHANGE: awaitable queues caolan/async#1641
  • Removed ignore dependency list from .ncurc.json as all issues have been resolved
  • Following dependencies were updated:
    async 2.6.2 → 3.1.0
    node-rdkafka 2.6.1 → 2.7.1
    raw-body 2.4.0 → 2.4.1
    sinon 7.2.4 → 7.4.2
    tap-xunit 2.3.0 → 2.4.1
    tape 4.10.1 → 4.11.0

Maintenance updates:

  • Replaced central-services-shared dep with central-service-logger
  • Migrated from istanbul to nyc
  • Moved unit tests to a test/unit folder to be consistent with other repos
  • Added editorconfig, eslintignore, & eslintrc for consistency with other repos

@mdebarros
Large maintenance update:
45180d8 
- replaced central-services-shared dep with central-service-logger
- migrated from istanbul to nyc
- updates to dependencies in general
- moved unit tests to a test/unit folder to be consistent with other repos
- added editorconfig, eslintignore, & eslintrc for consistency with other repos
@mdebarros
Fix to path changes with previous commit
0eaba67
@mdebarros
Updates to all dependencies
9fe802e 
- Fixes for latest version of async which introduced breaking change --> caolan/async#1641
- Removed ignore dep from .ncurc.json as all issues have been resolved
- Following dependencies were updated:
 async          2.6.2  →   3.1.0
 node-rdkafka   2.6.1  →   2.7.1
 raw-body       2.4.0  →   2.4.1
 sinon          7.2.4  →   7.4.2
 tap-xunit      2.3.0  →   2.4.1
 tape          4.10.1  →  4.11.0
@mdebarros mdebarros self-assigned this Sep 16, 2019
rmothilal
rmothilal approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@rmothilal rmothilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy

@mdebarros mdebarros merged commit d8341e5 into mojaloop:master Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmothilal rmothilal rmothilal approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k

@ggrg ggrg Awaiting requested review from ggrg

@gibaros gibaros Awaiting requested review from gibaros

@ndonnan ndonnan Awaiting requested review from ndonnan

@oderayi oderayi Awaiting requested review from oderayi

@vgenev vgenev Awaiting requested review from vgenev

Assignees

@mdebarros mdebarros

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mdebarros @rmothilal