Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mojaloop/3050): implemented settlement model rules engine (#934) #942

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

mdebarros
Copy link
Member

  • feat: implemented settlement model rules engine

  • chore: removed commented code

vijayg10 and others added 17 commits January 16, 2023 18:10
* feat: implemented settlement model rules engine

* chore: removed commented code
…ssages (#936)

* feat: add option to include decoded transaction in messages

* chore: test

* chore: audit

* chore: remove

* chore: fix dep breaking test

* is this really a dep failure?

* cleanup

* yep, which dep is it

* potentially knex migration and seeding issue!

* chore: add explanation and error message log

* chore: remove unneeded stringify
…enarios (#937)

* feat(mojaloop/#3080): add validator for ilpPacket and unhappy test scenarios

* chore: update int tests

* chore: lint

* revert

* chore: move code
* feat: implemented settlement model rules engine

* chore: removed commented code

* feat: initial changes

* feat: refactor rule engine integration

* feat: refactor the rules engine

* chore: move rule/decode logic and refactor transfer save

* fix: payer limit issue in integration tests

* fix: lint issues and integration tests

* chore: changed default value for settlement model

* fix: issue-with-failed-transfers

* fix: unit test

* fix: transferStateAndPositionUpdate

* fix: some fixes

* fix: settlement model chache issue

* fix: lint issues

* chore(snapshot): 16.4.0-snapshot.0

* chore(snapshot): 16.4.0-snapshot.1

* fix: build step for snapshot releases

* chore(snapshot): 16.4.0-snapshot.2

* fix: settlement model rules engine default issue

* chore(snapshot): 16.4.0-snapshot.3

* chore: improve coverage

* fix: integration tests

* chore: removed console log

* chore: updated dependencies

* fix: lint issues

* fix: audi issue

* fix: added missing param to config file

* fix: removed INCLUDE_DECODED_TRANSACTION_OBJECT

* fix: lint

---------

Co-authored-by: Kevin <kleyow@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ kleyow
✅ vijayg10
❌ Vijay Kumar


Vijay Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

sonarcloud bot commented Feb 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
27.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants