Skip to content

Commit

Permalink
fix(mojaloop/#3152): initial open settlementWindow is failing on clea…
Browse files Browse the repository at this point in the history
…n install (#946)

fix(mojaloop/#3152): initial open settlementWindow is failing on clean install - mojaloop/project#3152
- updated seeds/settlementWindow2Open.js to
    - handle an array being returned from the knex.insert operation
    - to throw unexpected errors to force the migration scripts to hard fail, so we don't have a soft failure in future that requires deep "investigation" to find something that should be easily noticed
- fixed unit tests, improved descriptions and code-coverage

This issue was introduced in [Knex v2.4.0](https://github.com/knex/knex/releases/tag/2.4.0) with the following change:
- MySQL: Add assertion for basic where clause not to be object or array - [knex/issues/#1227](knex/knex#1227) - knex/knex#1227

chore: updated dependencies and fixed unit tests
- updated dependencies
- ~fixed api changes on Glob dependency~ (reverted due to a license issue with v9.x)
- Glob dependency added to upgrade exception list due to v9.x introducing a dependency Package "path-scurry@1.6.1" licensed under "BlueOak-1.0.0" which is not permitted by the Mojaloop License Policy
  • Loading branch information
mdebarros committed Mar 2, 2023
1 parent 4780580 commit 111d393
Show file tree
Hide file tree
Showing 5 changed files with 244 additions and 148 deletions.
4 changes: 3 additions & 1 deletion .ncurc.yaml
Expand Up @@ -5,5 +5,7 @@ reject: [
# TODO: New versions from 2.2.0 onwards introduce a newer incompatible version of the ILP-Packet that is not compatible with the Mojaloop Specification
"ilp-packet",
# TODO: v6+ (ref: https://github.com/sindresorhus/get-port/releases/tag/v6.0.0) is an ESM library and thus not compatible with CommonJS. Future story needed to resolve.
"get-port"
"get-port",
# TODO: Glob v9.x introducing a dependency Package "path-scurry@1.6.1" which is licensed under "BlueOak-1.0.0" which is not permitted by the Mojaloop License Policy
"glob"
]

0 comments on commit 111d393

Please sign in to comment.