Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get missing glyphs - Use freetype instead of fonttools + fixes #26

Merged
merged 18 commits into from Oct 8, 2023
Merged

Get missing glyphs - Use freetype instead of fonttools + fixes #26

merged 18 commits into from Oct 8, 2023

Conversation

moi15moi
Copy link
Owner

@moi15moi moi15moi commented Aug 15, 2023 •
edited

fontTools seems to have multiple issue to decode the cmap table.

So, we replace fontTools with freetype which seems way more stable. Libass also use freetype to decode the cmap.

It also resolve the problem @LYS1THEA reported here: #20 (comment)

Also, this PR resolve 2 issues:

  • Deal correctly with symbol cmap by trying to guess the encoding.
  • Deal correctly with unicode cmap. We previously correctly deal with those, but a bug was introduce in 2f57e0f

@moi15moi
[font_parser] get_cmap_encoding replace parameter by primitive variable
f921e20
@moi15moi
[font] get_missing_glyphs replace fontTools by freetype
8c2aa79 
fontTools seems to have multiple issue to decode the cmap table.
- fonttools/fonttools#3256
- fonttools/fonttools#3060

So, we replace it by freetype
@moi15moi
[font] Ignore freeType synthesized cmap
4fd76a3
@moi15moi
[font_parser] CMAP_ENCODING_MAP replace utf_16_be by unicode
d54cd4f
@moi15moi
[font] get_missing_glyphs - Deal correctly with unicode cmap
4038cb4
@moi15moi
Add test for get_missing_glyph for font with unicode cmap
20b465e
@moi15moi
Add test for character not valid for an cmap
5144758
@moi15moi
Create [Symbol Font] Find unique char by ansi code page.py
2f53430
@moi15moi
[font_parser] Add get_symbol_cmap_encoding
2d692d5
@moi15moi
Adapt get_missing_glyphs with symbol font
7f83c49
@moi15moi
[font_parser] Add explanation for glyph char limit
5f2a9e0
@moi15moi
[font] get_missing_glyphs - Add support_only_ascii_char_for_symbol_fo…
ecdb59a 
…nt param
@moi15moi
[test_font] Add test_font_get_missing_glyphs_cmap_encoding_0
6648181
@moi15moi
[test_font] Remove unnecessary test with get_missing_glyphs
7470710
@moi15moi
[test_font] Add comment to explain why we use "é" to test get_missing…
4e2bd9b 
…_glyphs
@moi15moi
[test_font] Add char to test properly get_missing_glyphs with mac font
28977fd
@moi15moi
[font] Correct get_missing_glyphs documentation
c9d595d
@moi15moi
[font_parser] Add UNIQUE_ADOBE_GLYPH_NAME_BY_CODE_PAGE typing and exp…
63c34c8 
…lanation how we build it
@moi15moi moi15moi changed the title Get missing glyphs - Use freetype instead of fonttools Get missing glyphs - Use freetype instead of fonttools + fixes Oct 8, 2023
@moi15moi moi15moi merged commit c245aa3 into main Oct 8, 2023
@moi15moi moi15moi deleted the get-missing-glyphs-use-freetype-instead-of-fonttools branch May 5, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@moi15moi