docs(test-runner-module-mocking): ✏️ test-moduleMocking details on plugin import order #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin import order Adding details on the order of plugin import in test config. Module mocking must be in first position to avoid conflict with modified path due to other plugins. + refactoring
🦋 Changeset detectedLatest commit: 1cac4c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tmsns
reviewed
Mar 8, 2024
| @@ -37,15 +37,37 @@ export function moduleMockingPlugin(): Plugin { | |||
| const namedExports = exports.map(e => e.n).filter(n => n !== 'default'); | |||
| const hasDefaultExport = exports.some(e => e.n === 'default'); | |||
|
|
|||
| body = ` | |||
| body = generateInterceptedModuleBody(body, url, namedExports, hasDefaultExport); | |||
There was a problem hiding this comment.
There is no real reason to extract this in a separate method, right? Can you revert this change?
| @@ -20,6 +20,14 @@ describe('moduleMockingPlugin', function test() { | |||
| }); | |||
| }); | |||
|
|
|||
| it('can intercept server relative modules with stub', async () => { | |||
There was a problem hiding this comment.
All tests are using stubs. :-)
Example:
We don't want to test all different stubbing libraries.
So, you can remove this extra test.
| @@ -38,6 +38,8 @@ export default { | |||
| }; | |||
| ``` | |||
|
|
|||
| Take care of the plugins order, some plugins can modify path of imported modules and moduleMockingPlugin may be not able to retreive them correctly, so it's advise to use it first in the list. | |||
There was a problem hiding this comment.
Suggested change
| Take care of the plugins order, some plugins can modify path of imported modules and moduleMockingPlugin may be not able to retreive them correctly, so it's advise to use it first in the list. | |
| When using multiple plugins, make sure `moduleMockingPlugin()` rune before any other plugin that changes import resolutions using the `resolveImport()` hook (eg. `rollupAdapter()`). The interception mechanism of `moduleMockingPlugin()` needs to run before those transformations. | |
| Therefor, it is advised to have `moduleMockingPlugin()` as the first plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs(test-runner-module-mocking): ✏️ test-moduleMocking details on plugin import order
Adding details on the order of plugin import in test config. Module mocking must be in first position to avoid conflict with modified path due to other plugins. + refactoring
What I did