fix(test-runner): unify visual-written representation of skipped tests #2603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0613039 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
oscarmarina
force-pushed
the
unify-visual-written-skip-tests
branch
from
d7ce6ab
to
0889e3f
Compare
Westbrook
approved these changes
May 10, 2024
Westbrook
force-pushed
the
unify-visual-written-skip-tests
branch
from
2d9b31d
to
0613039
Compare
|
Thanks for the review, @Westbrook !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Unifying Visual and Written Representation of 'Skipped' Information for better comprehension - cognitive accessibility.
Presently, when a test is skipped, the visual representation uses a red "X" symbol, while the written summary denotes the skip with a gray label.
To enhance understanding and cognitive accessibility, I suggest introducing a new visual symbol, “-,” rendered in a subdued color, to complement the existing skipped label. This alignment of visual and written representations aims to improve clarity and consistency.
Visual
x red- dim