Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare release of CJS and Node Resolution updates #2129

Merged
merged 7 commits into from
Mar 11, 2023
Merged

Prepare release of CJS and Node Resolution updates #2129

merged 7 commits into from
Mar 11, 2023

Commits on Feb 22, 2023

  1. fix (dev-server-rollup): support child plugins in resolution algorithm 

    It is possible a rollup plug injects its own child plugins by hooking
into the rollup `options` hook and mutating the options to have extra
plugs.

This change introduces a check for such plugins and calls them before
the host plugin in case they successfully resolve a path first.

Similarly, the `resolve` method of plugins receives an options object to
hold state for the resolution plugins. We currently lose this object
when calling through to `resolveImport`, which can confuse third-party
plugins/resolvers heavily.

To fix this, `resolveImport` now also accepts a `resolverOptions` so we
can pass it on when calling child plugins.
    @43081j @Westbrook
    43081j authored and Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    2619968 View commit details
    Browse the repository at this point in the history

  2. fix (dev-server-rollup): respect skipSelf

    @43081j @Westbrook
    43081j authored and Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    13022b2 View commit details
    Browse the repository at this point in the history

  3. fix (dev-server-rollup): fix ImportSkip map order

    @lucaelin @Westbrook
    lucaelin authored and Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    09d3010 View commit details
    Browse the repository at this point in the history

  4. feat (dev-server-rollup): pass through resolve options

    @43081j @Westbrook
    43081j authored and Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    feb2981 View commit details
    Browse the repository at this point in the history

  5. feat: extract resolve options to plugin definition

    @43081j @Westbrook
    43081j authored and Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    b46163a View commit details
    Browse the repository at this point in the history

  6. build: run canary release job with node@16

    @Westbrook
    Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    01c46b1 View commit details
    Browse the repository at this point in the history

  7. Include change set

    @Westbrook
    Westbrook committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    d78e960 View commit details
    Browse the repository at this point in the history